Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-critics-browser-issue #724

Merged
merged 3 commits into from
Mar 21, 2024
Merged

fix-critics-browser-issue #724

merged 3 commits into from
Mar 21, 2024

Conversation

tesonep
Copy link
Contributor

@tesonep tesonep commented Mar 20, 2024

Fix pharo-project/pharo#16314

  • Fixing the removal of categories.
  • Enabling or disabling buttons if needed
  • Organizing the creation of presenters.

@tesonep
- Organizing the creation of presenters.
2154252 
- Fixing the removal of categories. 
- Enabling or disabling buttons if needed
@tesonep tesonep requested a review from guillep March 20, 2024 11:18
@Ducasse
Copy link
Contributor

Ducasse commented Mar 20, 2024

@tesonep
Following tests are related

StCritiqueRuleSelectorPresenterTest
 ✗ #testRemoveAll (18ms)
TestFailure: Assertion failed
StCritiqueRuleSelectorPresenterTest(TestAsserter)>>assert:description:resumable:
StCritiqueRuleSelectorPresenterTest(TestAsserter)>>assert:description:
StCritiqueRuleSelectorPresenterTest(Object)>>assert:
StCritiqueRuleSelectorPresenterTest>>testRemoveAll ...assert: rulesSelectorPresenter selectedRules isEmpty
StCritiqueRuleSelectorPresenterTest(TestCase)>>performTest
 ✗ #testRemoveSelectedComposite (24ms)
TestFailure: Assertion failed
StCritiqueRuleSelectorPresenterTest(TestAsserter)>>assert:description:resumable:
StCritiqueRuleSelectorPresenterTest(TestAsserter)>>assert:description:
StCritiqueRuleSelectorPresenterTest(Object)>>assert:
StCritiqueRuleSelectorPresenterTest>>testRemoveSelectedComposite ...assert: rulesSelectorPresenter selectedRules isEmpty
StCritiqueRuleSelectorPresenterTest(TestCase)>>performTest

@tesonep tesonep merged commit 29d0dd6 into pharo-spec:Pharo12 Mar 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillep guillep Awaiting requested review from guillep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NotFound Error in Critics browser
2 participants
@tesonep @Ducasse